dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 200 forks source link

Handle upgrade with dashboard. #1290

Closed artursouza closed 1 year ago

artursouza commented 1 year ago

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: https://github.com/dapr/cli/issues/1289

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1290 (b5534d4) into master (337eab4) will decrease coverage by 0.17%. The diff coverage is 12.28%.

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
- Coverage   27.08%   26.92%   -0.17%     
==========================================
  Files          38       39       +1     
  Lines        3803     3852      +49     
==========================================
+ Hits         1030     1037       +7     
- Misses       2702     2743      +41     
- Partials       71       72       +1     
Impacted Files Coverage Δ
pkg/kubernetes/common.go 0.00% <0.00%> (ø)
pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ø)
pkg/kubernetes/uninstall.go 0.00% <0.00%> (ø)
pkg/kubernetes/upgrade.go 15.38% <0.00%> (-4.32%) :arrow_down:
pkg/kubernetes/dashboard_chart.go 70.00% <70.00%> (ø)
mukundansundar commented 1 year ago

superseded by #1284