dapr / cli

Command-line tools for Dapr.
Apache License 2.0
317 stars 202 forks source link

fix(test): correct test roles check based on runtime version #1295

Closed sicoyle closed 1 year ago

sicoyle commented 1 year ago

Description

My other PR fails inconsistently for a check on the dashboard role for v1.11 runtime. This will prevent part of the issue. The timing related issue we can save for another PR/investigation :)

Issue reference

https://github.com/dapr/cli/pull/1280#issuecomment-1565130574

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

sicoyle commented 1 year ago

Can you please restart the build on my other PR if/when this is merged? https://github.com/dapr/cli/pull/1280

sicoyle commented 1 year ago

A can of worms I have found 🪱

    utils.go:112: ⚠  Could not update sidecar metadata for cliPID: PUT http://127.0.0.1:49987/v1.0/metadata/cliPID giving up after 5 attempt(s): Put "http://127.0.0.1:49987/v1.0/metadata/cliPID": dial tcp 127.0.0.1:49987: connect: connection refused
    utils.go:112: ℹ️  Updating metadata for appPID: 11488
    utils.go:112: ⚠  Could not update sidecar metadata for appPID: PUT http://127.0.0.1:49987/v1.0/metadata/appPID giving up after 5 attempt(s): Put "http://127.0.0.1:49987/v1.0/metadata/appPID": dial tcp 127.0.0.1:49987: connect: connection refused
    utils.go:112: ℹ️  Updating metadata for app command: bash -c sleep 60 ; exit 1
    utils.go:112: ⚠  Could not update sidecar metadata for appCommand: PUT http://127.0.0.1:49987/v1.0/metadata/appCommand giving up after 5 attempt(s): Put "http://127.0.0.1:49987/v1.0/metadata/appCommand": dial tcp 127.0.0.1:49987: connect: connection refused
    utils.go:112: ℹ️  
    utils.go:112: terminated signal received: shutting down
    utils.go:112: ✅  Exited App successfully
    utils.go:120: 
            Error Trace:    /Users/runner/work/cli/cli/tests/e2e/standalone/utils.go:120
                                        /Users/runner/work/cli/cli/tests/e2e/standalone/stop_test.go:28
            Error:          Received unexpected error:
                            exit status 1
            Test:           TestStandaloneStop
            Messages:       dapr didn't exit cleanly
yaron2 commented 1 year ago

Closing as covered in https://github.com/dapr/cli/pull/1280