dapr / cli

Command-line tools for Dapr.

Apache License 2.0

315 stars 200 forks source link

Fix checks for container runtime installation #1307

Closed shubham1172 closed 1 year ago

shubham1172 commented 1 year ago

Description

The previous logic to check if a container runtime is installed or not, used an OR logic. This resulted in issues like #1300

containerRuntimeAvailable := utils.IsDockerInstalled() || utils.IsPodmanInstalled()

The new fix is to check for a specific runtime based on the flag passed by the user.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1300

Checklist

[X] Code compiles correctly
[X] Created/updated tests
[ ] Extended the documentation

mukundansundar commented 1 year ago

Description

The previous logic to check if a container runtime is installed or not, used an OR logic. This resulted in issues like #1300
containerRuntimeAvailable := utils.IsDockerInstalled() || utils.IsPodmanInstalled() 
I did remember that a fix was made previously, so this is the issue :). Nice find.