Upgrade go to 1.21 - Githubissues

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (668bab4) 22.76% compared to head (ec0d437) 22.76%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1331 +/- ## ======================================= Coverage 22.76% 22.76% ======================================= Files 40 40 Lines 4713 4713 ======================================= Hits 1073 1073 Misses 3562 3562 Partials 78 78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shubham1172 commented 8 months ago

@pravinpushkar could you please resolve the conflicts?

pravinpushkar commented 8 months ago

@pravinpushkar could you please resolve the conflicts?

yes, I will work on this.

pravinpushkar commented 7 months ago

You also need to update the linter version for Go 1.21 support.

In Contrib we are now using v1.55.2. I suggest switching to that version.

https://github.com/dapr/cli/blob/master/.github/workflows/dapr_cli.yaml#L32

You may need to change the golangci-lint configuration and fix some new linter errors. See my PR: dapr/components-contrib#3251

Thanks for the suggestion. Just wondering, should not lint fail in this PR, all checks seems to be paasing. I will take a look at the PR.

dapr / cli

Upgrade go to 1.21 #1331

Codecov Report