search

dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 197 forks source link

Initial implementation of multi app run for Kubernetes Dev #1333

Closed mukundansundar closed 10 months ago

mukundansundar commented 10 months ago

Description

supersedes #1330 closes #1324

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 0.37% and project coverage change: -4.48% :warning:

Comparison is base (6738eef) 27.53% compared to head (b1fbbba) 23.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1333 +/- ## ========================================== - Coverage 27.53% 23.06% -4.48% ========================================== Files 39 40 +1 Lines 3915 4674 +759 ========================================== Hits 1078 1078 - Misses 2760 3519 +759 Partials 77 77 ``` | [Files Changed](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [pkg/kubernetes/components.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvY29tcG9uZW50cy5nbw==) | `55.55% <0.00%> (-11.12%)` | :arrow_down: | | [pkg/kubernetes/configurations.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvY29uZmlndXJhdGlvbnMuZ28=) | `58.66% <0.00%> (-9.03%)` | :arrow_down: | | [pkg/kubernetes/kubernetes.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMva3ViZXJuZXRlcy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/logs.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvbG9ncy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/renew\_certificate.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvcmVuZXdfY2VydGlmaWNhdGUuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/run.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvcnVuLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/stop.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvc3RvcC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/uninstall.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvdW5pbnN0YWxsLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/kubernetes/upgrade.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL2t1YmVybmV0ZXMvdXBncmFkZS5nbw==) | `15.29% <0.00%> (-0.10%)` | :arrow_down: | | [pkg/runexec/runexec.go](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-cGtnL3J1bmV4ZWMvcnVuZXhlYy5nbw==) | `20.00% <0.00%> (-6.23%)` | :arrow_down: | | ... and [4 more](https://app.codecov.io/gh/dapr/cli/pull/1333?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pravinpushkar commented 10 months ago

LGTM. Just a couple of nits.

mukundansundar commented 10 months ago

E2E for this in #1336