search

dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 197 forks source link

Mutli-app-run should monitor processes and close on exit #1354

Open paulyuk opened 9 months ago

paulyuk commented 9 months ago

Describe the proposal

Today if you do the multi app run, e.g. on Workflow quickstart, it has some unexpected behaviors where the dapr console apps all complete and exit, but dapr run keeps running. It looks like dapr run never will exit which is unexpected, and you have to force exit with CTL C etc.

The mainline proposal is we should add process monitoring and by default exit dapr run when *all dapr app processes have exited.

There is also a case where some but not all dapr processes exit. My suggestion and leaning is we do not exit dapr in this case, because there might be valid reasons for a job to exit, but keep the services alive. We could however add a user config with a short circuit where if any processes exit, the whole dapr run exits.

Release Note

Multi-app-run now monitors processes and exits when dapr applications exit/stop.

dapr-bot commented 8 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

dapr-bot commented 7 months ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

pravinpushkar commented 7 months ago

This got closed as stale.