search

dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 197 forks source link

[1.12] Delete injector mutating webhook on downgrade from 1.12 to 1.11 #1359

Open JoshVanL opened 8 months ago

JoshVanL commented 8 months ago

If a downgrade is occurring for 1.12 to 1.11, delete the injector mutating webhook so that 1.11 helm chart installs correct CA bundle. Re-create webhook in the event of upgrade failing.

See: https://github.com/dapr/dapr/issues/7055#issuecomment-1768573741

codecov[bot] commented 8 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (1d60280) 22.76% compared to head (b5d5fc7) 22.59%.

Files Patch % Lines
pkg/kubernetes/upgrade.go 0.00% 37 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.12 #1359 +/- ## ================================================ - Coverage 22.76% 22.59% -0.18% ================================================ Files 40 40 Lines 4713 4749 +36 ================================================ Hits 1073 1073 - Misses 3562 3598 +36 Partials 78 78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dapr-bot commented 6 months ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

mukundansundar commented 5 months ago

@JoshVanL is this PR still relevant based on the conversation in issue https://github.com/dapr/dapr/issues/7055#issuecomment-1770742843

cc @yaron2

JoshVanL commented 5 months ago

@JoshVanL is this PR still relevant based on the conversation in issue https://github.com/dapr/dapr/issues/7055#issuecomment-1770742843

cc @yaron2

@mukundansundar yes, this PR was intended to improve downgrade support by covering all 1.11 releases, not only those with the helm chart fixes.