search

dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 197 forks source link

[WIP] Add --waitTimeout flag to dapr stop command #1363

Closed nikitasarawgi closed 7 months ago

nikitasarawgi commented 8 months ago

Description

Adding a new --waitTimeout flag to the dapr stop command - This flag allows users to specify a timeout duration in seconds, which determines the maximum time the command will wait for the process to exit gracefully. If the process remains active after this timeout, the command will forcefully terminate it. The default --waitTimeout value is set to 15 seconds.

WIP - This is implemented only for linux for now. Currently learning how windows event signals work. Unit tests run successfully.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1160

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

shubham1172 commented 8 months ago

Hi @nikitasarawgi, welcome to Dapr 👋🏻 Could you please fix the DCO check? https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work

dapr-bot commented 7 months ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot commented 7 months ago

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!