search

dapr / components-contrib

Community driven, reusable components for distributed apps
Apache License 2.0
542 stars 469 forks source link

Remove dependency on Azure namespace for pubsub.azure.eventhubs conformance test #1641

Open shubham1172 opened 2 years ago

shubham1172 commented 2 years ago

Each time Azure infrastructure namespace changes, like #1620, it will create issues like #1637. This task is to remove that dependency.

berndverst commented 2 years ago

in 1 year we have never changed this name, and we generally won't be changing it. The only reason is that we migrated to a new Azure subscription and couldn't reuse existing resource naming.

Unfortunately this part of the test cannot be made dynamic today. https://github.com/dapr/components-contrib/blob/master/tests/config/pubsub/tests.yml allows overloading / injecting constant values only, with the exception of generating UUIDs.

I suppose there is a new syntax that could be introduced which would need to be supported here: https://github.com/dapr/components-contrib/blob/master/tests/conformance/common.go

Which could then use values provided by environment variables. Today we only have $((uuid)). Maybe we can add $((env:SOMETHING)) which will look for the environment variable SOMETHING and use its value.

Anyways.. this is extremely overkill for something that will not likely change for the next year or more.

I consider this issue P3 or P4