dapr / components-contrib

Community driven, reusable components for distributed apps
Apache License 2.0
544 stars 473 forks source link

Hashicorp Vault Secret Store - To support cert. rotation and renewals #1858

Open Radhikabollineni opened 2 years ago

Radhikabollineni commented 2 years ago

Enhance Hashicorp Vault Secret store to support password/ cert. renewals and publish the notification/ event when change takes place.

dapr-bot commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

vivekthakur-ai commented 2 years ago

Hi,

Please consider a scenario when a microservice is connected to Hashicorp Vault using Dapr and a database. Hashicorp vault is managing the database credentials (Static role for this scenario) and Microservice is getting the credentials from Dapr (by Vault) and Creating a connection pool to connect to database using the credentials and performs the operation. Suppose there is a password rotation happens by vault and database password got changed and vault also rotates its credentials. This scenario won't affect Microservice for the new connection pool creation as it will fetch the credentials from Vault. However the Old pool will still in the active state with old credentials so it will try to create new connection and get the exception as credentials are old and not updated. There is a need of some mechanism to inform the microservice to nullify the pool / pool credentials on the password rotation at database through Vault. i.e. If there is an updation of the password / Lease at Vault then Dapr should trigger some event back to microservice and inform as there is an update of password / lease happened at Vault & database so Microservice can also refresh / nullify the current connection pool.

dapr-bot commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

rabollin commented 2 years ago

Tagged for 1.10

yaron2 commented 2 years ago

Tagged for 1.10

We do not tie certification efforts to a particular milestone. Also, certifying this component for GA does not require certificate renewals. These are two separate things.

rabollin commented 2 years ago

/assign

dapr-bot commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

mukundansundar commented 1 year ago

👋

rabollin commented 1 year ago

The Certification of Hashicorp to stable is being handled by other issue, this will be targeted to enable the Hashicorp vault supporting cert. / password renewals and publishing an event when renewal takes place.

@mukundansundar - can you help update the issue description to - Feature request to support password/ cert. renewals and publish the notification/ event when change takes place in Hashicorp vault secret store.

mukundansundar commented 1 year ago

The Certification of Hashicorp to stable is being handled by other issue, this will be targeted to enable the Hashicorp vault supporting cert. / password renewals and publishing an event when renewal takes place.

@mukundansundar - can you help update the issue description to - Feature request to support password/ cert. renewals and publish the notification/ event when change takes place in Hashicorp vault secret store.

Done

dapr-bot commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

rabollin commented 1 year ago

//comment

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

rabollin commented 1 year ago

//comment

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.