search

dapr / components-contrib

Community driven, reusable components for distributed apps
Apache License 2.0
544 stars 473 forks source link

Configurable Acknowledgement Deadline for GCP Pub/Sub Component #3421

Closed mahparaashley closed 1 month ago

mahparaashley commented 4 months ago

Describe the proposal

Issue Description Currently, the acknowledgment deadline for messages in the GCP Pub/Sub component is hardcoded (see pubsub.go#L444). This can be limiting for users who need different settings based on their specific use cases, such as different workload characteristics or message processing times.

Proposed Change

I propose making the ack deadline configurable through the component's metadata. This would allow users to specify an appropriate acknowledgment time based on their application's requirements, enhancing the component's flexibility and usability.

Potential Benefits

Flexibility: Users can optimize the ack deadline based on the processing time required by their applications, which can vary significantly.

Reliability: Properly configured ack times can improve message processing reliability, reducing the chances of message redelivery and potential duplicates.

Usability: Makes the component more adaptable to a wider range of use cases and environments. Additional Context

The current hardcoded value may not suit all environments or applications, especially those with longer or variable processing times. Allowing users to configure this value can help ensure that the component is more broadly applicable.

mahparaashley commented 4 months ago

https://github.com/dapr/components-contrib/pull/3422

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.