search

dapr / components-contrib

Community driven, reusable components for distributed apps
Apache License 2.0
540 stars 467 forks source link

Ability to Generate SAS url for Azure blob Storage #3484

Closed bhagya05 closed 1 week ago

bhagya05 commented 1 month ago

Describe the feature

Users should be able to generate SAS url for their container or specific blob. https://learn.microsoft.com/en-us/azure/ai-services/translator/document-translation/how-to-guides/create-sas-tokens?tabs=blobs

Release Note

RELEASE NOTE:

berndverst commented 1 month ago

@bhagya05 please use managed identity credentials or Azure CLI Credential instead. SAS tokens are inferior from a security perspective and their use is discouraged.

Dapr is also not a access management solution. The access to your storage account should be managed outside of Dapr. As such, you should create a SAS URL manually or via Azure Storage Management SDKs.

I'll defer to @ItalyPaleAle's opinion here, but my opinion (as a maintainer and Microsoft employee) is that we should not implement this feature.

ItalyPaleAle commented 1 month ago

I agree with Bernd on the security implications, however there could be use cases where having a SAS token is required (legacy apps for example).

I'm happy to accept a PR to add this feature to the binding if someone wants to contribute it

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 week ago

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.