dapr / components-contrib

Community driven, reusable components for distributed apps
Apache License 2.0
548 stars 480 forks source link

1.13 Fix kafka metadata to HTTP headers conversion of invalid characters #3512

Closed antontroshin closed 1 month ago

antontroshin commented 2 months ago

Description

Sending special characters in Kafka message metadata will cause an error when metadata is converted to HTTP headers. Error:

WARN[0009] Error processing Kafka message: topic/0/13 [key=]. Error: error returned from app channel while sending pub/sub event to app: retriable error occurred: Post "http://127.0.0.1:56012/handle-message": net/http: invalid header field value for "My-Header". Retrying...

Go validates header value using the function ValidHeaderFieldValue, for reference and allowed format, see more here

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3503

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

github-actions[bot] commented 1 month ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] commented 1 month ago

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!