dapr / dashboard

General purpose dashboard for Dapr
Apache License 2.0
181 stars 47 forks source link

Add test coverage for docker compose platform type #252

Closed timcallaghan closed 1 year ago

timcallaghan commented 1 year ago

Adding missing test coverage for previous PR - https://github.com/dapr/dashboard/pull/217

timcallaghan commented 1 year ago

Hi @artursouza - here's a PR adding some test coverage for my previous PR

codecov[bot] commented 1 year ago

Codecov Report

Merging #252 (a5d05d9) into master (4c87fc7) will increase coverage by 18.88%. The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master     #252       +/-   ##
===========================================
+ Coverage    8.67%   27.56%   +18.88%     
===========================================
  Files           7        7               
  Lines         795      798        +3     
===========================================
+ Hits           69      220      +151     
+ Misses        720      554      -166     
- Partials        6       24       +18     
Impacted Files Coverage Δ
pkg/components/components.go 35.00% <0.00%> (+35.00%) :arrow_up:
pkg/instances/instances.go 22.39% <100.00%> (+14.83%) :arrow_up:

... and 1 file with indirect coverage changes

Mamotchenko commented 1 year ago

Any news?

oridotaoyebode commented 1 year ago