Closed fabrizziocht closed 1 year ago
Thanks for your contribution! Will review soon
@fabrizziocht the FOSSA check is irrelevant for this PR so can be wavered. Did you test your current changes locally for any regressions and to verify stateful sets are visualized properly?
Merging #255 (c984356) into master (8f4e17a) will decrease coverage by
1.78%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #255 +/- ##
=========================================
- Coverage 10.45% 8.67% -1.78%
=========================================
Files 7 7
Lines 660 795 +135
=========================================
Hits 69 69
- Misses 585 720 +135
Partials 6 6
Impacted Files | Coverage Δ | |
---|---|---|
pkg/instances/instances.go | 7.55% <0.00%> (-2.68%) |
:arrow_down: |
Hello @yaron2 , correct I tested locally in k8s rebuilding the Dapr dashboard and deploying it inside the dapr-system namespace. In order to reproduce the steps for this tests I've published a folder called tests_statefulset in a different branch if you want to review it: https://github.com/fabrizziocht/dapr-dashboard/tree/tests-sts/tests_statefulset
This example generates a docker image, deploys in kubernetes granting permissions to read statefulset objects and also deploys two nginx apps using deployment and statefulset. The script can include the flag --use-helm to test the helmchart that adds the resource "statefulset" in the Role/ClusterRole CDR.
Let me share you some screenshots about my local tests:
1. New Dapr dashboard pod using my local built image:
2. nginx app examples 1 deployment + 1 statefulset:
3. Angular App showing both apps:
4. Tabs about statefulset information:
5. Network traces without any bug:
Please let me know if you need additional information. Regards, Fabri
Changes made in instances.go