dapr / dashboard

General purpose dashboard for Dapr
Apache License 2.0
181 stars 47 forks source link

Include StatefulSets in application list #255

Closed fabrizziocht closed 1 year ago

fabrizziocht commented 1 year ago

Changes made in instances.go

yaron2 commented 1 year ago

Thanks for your contribution! Will review soon

yaron2 commented 1 year ago

@fabrizziocht the FOSSA check is irrelevant for this PR so can be wavered. Did you test your current changes locally for any regressions and to verify stateful sets are visualized properly?

codecov[bot] commented 1 year ago

Codecov Report

Merging #255 (c984356) into master (8f4e17a) will decrease coverage by 1.78%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #255      +/-   ##
=========================================
- Coverage   10.45%   8.67%   -1.78%     
=========================================
  Files           7       7              
  Lines         660     795     +135     
=========================================
  Hits           69      69              
- Misses        585     720     +135     
  Partials        6       6              
Impacted Files Coverage Δ
pkg/instances/instances.go 7.55% <0.00%> (-2.68%) :arrow_down:
fabrizziocht commented 1 year ago

Hello @yaron2 , correct I tested locally in k8s rebuilding the Dapr dashboard and deploying it inside the dapr-system namespace. In order to reproduce the steps for this tests I've published a folder called tests_statefulset in a different branch if you want to review it: https://github.com/fabrizziocht/dapr-dashboard/tree/tests-sts/tests_statefulset

This example generates a docker image, deploys in kubernetes granting permissions to read statefulset objects and also deploys two nginx apps using deployment and statefulset. The script can include the flag --use-helm to test the helmchart that adds the resource "statefulset" in the Role/ClusterRole CDR.

Let me share you some screenshots about my local tests:

1. New Dapr dashboard pod using my local built image:

Captura de pantalla 2023-07-06 a la(s) 17 51 07

2. nginx app examples 1 deployment + 1 statefulset: Captura de pantalla 2023-07-06 a la(s) 17 51 54

3. Angular App showing both apps: Captura de pantalla 2023-07-06 a la(s) 17 52 17

4. Tabs about statefulset information: Captura de pantalla 2023-07-06 a la(s) 17 52 24 Captura de pantalla 2023-07-06 a la(s) 17 52 34 Captura de pantalla 2023-07-06 a la(s) 17 52 42 Captura de pantalla 2023-07-06 a la(s) 17 52 56

5. Network traces without any bug: Captura de pantalla 2023-07-06 a la(s) 17 53 24

Please let me know if you need additional information. Regards, Fabri