dapr / dashboard

General purpose dashboard for Dapr
Apache License 2.0
181 stars 47 forks source link

allow `.yml` files as components #270

Closed andrew-hillier closed 7 months ago

andrew-hillier commented 10 months ago

I suspect that this will resolve https://github.com/dapr/dashboard/issues/195

yaron2 commented 10 months ago

Thanks for this contribution!

yaron2 commented 7 months ago

@andrew-hillier please check why build tests are failing

andrew-hillier commented 7 months ago

@andrew-hillier please check why build tests are failing

Hey! It's due to slices only being available from go 1.21, so have updated to use this one instead, that was available for 1.19: https://pkg.go.dev/golang.org/x/exp/slices

Once the project is updated to 1.21+, then this can be updated to use the slices standard library package once more.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 27.84%. Comparing base (6d4c52a) to head (34f846e).

Files Patch % Lines
pkg/components/components.go 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #270 +/- ## ========================================== + Coverage 27.56% 27.84% +0.27% ========================================== Files 7 7 Lines 798 801 +3 ========================================== + Hits 220 223 +3 Misses 554 554 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yaron2 commented 7 months ago

@andrew-hillier thanks, we've now upgraded to Go 1.21. if you can resolve the conflicts that'd be great, and we can then merge

andrew-hillier commented 7 months ago

I'll revert the latest commit, as we can use slices from the standard lib too

andrew-hillier commented 7 months ago

@yaron2, had a little trouble with the DCO, but that should be ready to build now.