Closed andrew-hillier closed 7 months ago
Thanks for this contribution!
@andrew-hillier please check why build tests are failing
@andrew-hillier please check why build tests are failing
Hey! It's due to slices
only being available from go 1.21, so have updated to use this one instead, that was available for 1.19:
https://pkg.go.dev/golang.org/x/exp/slices
Once the project is updated to 1.21+, then this can be updated to use the slices
standard library package once more.
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 27.84%. Comparing base (
6d4c52a
) to head (34f846e
).
Files | Patch % | Lines |
---|---|---|
pkg/components/components.go | 60.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@andrew-hillier thanks, we've now upgraded to Go 1.21. if you can resolve the conflicts that'd be great, and we can then merge
I'll revert the latest commit, as we can use slices
from the standard lib too
@yaron2, had a little trouble with the DCO, but that should be ready to build now.
I suspect that this will resolve https://github.com/dapr/dashboard/issues/195