search

dapr / dashboard

General purpose dashboard for Dapr
Apache License 2.0
181 stars 47 forks source link

Bump Dashboard to Dapr 1.13 and recent client-go #276

Closed SantoDE closed 3 months ago

SantoDE commented 3 months ago

With the current Dashboard version, I came across an issue. Once a sidecar had the --enable-api-logging flag set, It wouldn't show up in the dashboard anymore because of an issue in the dependency code of Dapr CLI with version 1.10. To fix that, I bumped the dependencies and the related dependencies.

Since this is my first PR, happy to walk it through with the maintainers team to learn.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 27.93%. Comparing base (4bb66cd) to head (0234ab5).

Files Patch % Lines
pkg/configurations/configurations.go 36.36% 7 Missing :warning:
pkg/instances/instances.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #276 +/- ## ========================================== + Coverage 27.84% 27.93% +0.08% ========================================== Files 7 7 Lines 801 802 +1 ========================================== + Hits 223 224 +1 Misses 554 554 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.