search

dapr / docs

Dapr user documentation, used to build docs.dapr.io
https://docs.dapr.io
Creative Commons Attribution 4.0 International
994 stars 726 forks source link

`processingTimeout` and `redeliverInterval` units in the docs don't seem to match code. #4048

Closed francescortiz closed 7 months ago

francescortiz commented 7 months ago

Describe the issue The documentation about processingTimeout and redeliverInterval states that the format is "15s", but the implementation seems to expect milliseconds with no unit: https://github.com/dapr/components-contrib/blob/fff4d41fb76bcc81da09b875ee0966bcaca62b2b/common/component/redis/redis.go#L141

URL of the docs https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-redis-pubsub/

Expected content Field Required Details Example
redeliverInterval N The interval in milliseconds between checks for pending messages to redeliver. Defaults to "60000". "0" disables redelivery. "5000"
processingTimeout N The amount of time in milliseconds that a message must be pending before attempting to redeliver it. Defaults to "15000". "0" disables redelivery. "600000"

Additional context The behavior in our cluster matches the implementation.