dapr / docs

Dapr user documentation, used to build docs.dapr.io
https://docs.dapr.io
Creative Commons Attribution 4.0 International
987 stars 715 forks source link

Correct OTel endpointAddress argument (it's not a URL) #4067

Closed andrejpk closed 1 month ago

andrejpk commented 4 months ago

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

In addition, please fill out the following to help reviewers understand this pull request:

Description

The Tracing docs imply that you should use a URL in tracing.otel.endpointAddress but it's looking for a hostname or hostname:port

Issue reference

4068

msfussell commented 4 months ago

@andrejpk - Love this contribution. Any chance you could target this at the v1.13 branch now. This came at a time when we were close to the v1.13 release which is now the current branch

github-actions[bot] commented 3 months ago

Stale PR, paging all reviewers

hhunter-ms commented 3 months ago

hey @andrejpk - second Mark's comment; hopefully that'll get rid of all the extra commits in this PR.

github-actions[bot] commented 3 months ago

Stale PR, paging all reviewers

hhunter-ms commented 2 months ago

Resurrecting this PR - @andrejpk could you reopen this PR and point it to 1.13 instead of 1.12?

github-actions[bot] commented 1 month ago

Stale PR, paging all reviewers

andrejpk commented 1 month ago

Replaced with #4145