dapr / docs

Dapr user documentation, used to build docs.dapr.io
https://docs.dapr.io
Creative Commons Attribution 4.0 International
987 stars 715 forks source link

Add Kafka heartbeat interval and session timeout to component reference #4074

Closed denisbchrsk closed 1 week ago

denisbchrsk commented 4 months ago

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added documentation on the addition of session timeout and heartbeat interval in Kafka's component references (binding and pubsub).

Relevant to the PR that allows these parameters to be configurable in dapr/components-contrib#3375.

Issue reference

denisbchrsk commented 4 months ago

Fixed, also changed base branch to v1.14 after the release of v1.13. Also, this should probably be reviewed after dapr/components-contrib#3375 is approved and merged.

denisbchrsk commented 3 months ago

dapr/components-contrib#3375 has been merged, @msfussell can you take a look at this again?

denisbchrsk commented 2 months ago

It seems that in this PR #4099 which was merged recently, added the documentation of sessionTimeout and heartbeatInterval as is, directly from the component's metadata.yaml (without the suggested changes in this PR), so I'm assuming for this PR that I'll continue to try to improve the explanation on those fields.

msfussell commented 2 weeks ago

@denisbchrsk - Can you please take a look at this review. Would like to get this merged.

msfussell commented 2 weeks ago

@denisbchrsk - Another ping here. Thanks

denisbchrsk commented 2 weeks ago

@msfussell Apologies for the delay, I've added the changes requested by the review above.