Closed denisbchrsk closed 1 week ago
Fixed, also changed base branch to v1.14 after the release of v1.13. Also, this should probably be reviewed after dapr/components-contrib#3375 is approved and merged.
dapr/components-contrib#3375 has been merged, @msfussell can you take a look at this again?
It seems that in this PR #4099 which was merged recently, added the documentation of sessionTimeout
and heartbeatInterval
as is, directly from the component's metadata.yaml (without the suggested changes in this PR), so I'm assuming for this PR that I'll continue to try to improve the explanation on those fields.
@denisbchrsk - Can you please take a look at this review. Would like to get this merged.
@denisbchrsk - Another ping here. Thanks
@msfussell Apologies for the delay, I've added the changes requested by the review above.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added documentation on the addition of session timeout and heartbeat interval in Kafka's component references (binding and pubsub).
Relevant to the PR that allows these parameters to be configurable in dapr/components-contrib#3375.
Issue reference