dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 341 forks source link

Add support to DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT env. #1124

Closed artursouza closed 1 year ago

artursouza commented 1 year ago

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1110

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 1 year ago

Codecov Report

Merging #1124 (bcca04c) into master (574dc0c) will decrease coverage by 0.06%. The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   67.22%   67.16%   -0.06%     
==========================================
  Files         170      170              
  Lines        5687     5695       +8     
  Branches      605      607       +2     
==========================================
+ Hits         3823     3825       +2     
- Misses       1723     1727       +4     
- Partials      141      143       +2     
Flag Coverage Δ
net6 67.09% <25.00%> (-0.06%) :arrow_down:
net7 67.09% <25.00%> (-0.06%) :arrow_down:
netcoreapp3.1 67.12% <25.00%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Actors/Runtime/ActorRuntimeOptions.cs 77.27% <ø> (ø)
src/Dapr.Client/DaprClientBuilder.cs 100.00% <ø> (ø)
src/Shared/DaprDefaults.cs 61.53% <25.00%> (-16.24%) :arrow_down:
halspang commented 1 year ago

@artursouza - Can you fix your DCO?

artursouza commented 1 year ago

@artursouza - Can you fix your DCO?

Fixed.