search

dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 341 forks source link

set dapr-api-token to healthz requests when needed #1145

Closed famarting closed 1 year ago

famarting commented 1 year ago

Description

Implements the changes for https://github.com/dapr/dotnet-sdk/issues/1144

I followed the same pattern that is used in CreateInvokeMethodRequest which is the only other related to the use of the http client being used for the healthz requests.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1144

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

I think this changes don't require docs or test changes... existing tests and docs already cover this behaviour

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05% :warning:

Comparison is base (87329f6) 66.47% compared to head (431bd1b) 66.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1145 +/- ## ========================================== - Coverage 66.47% 66.42% -0.05% ========================================== Files 171 171 Lines 5754 5758 +4 Branches 624 626 +2 ========================================== Hits 3825 3825 - Misses 1782 1784 +2 - Partials 147 149 +2 ``` | [Flag](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1145/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [net6](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `66.42% <0.00%> (-0.05%)` | :arrow_down: | | [net7](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `66.42% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [src/Dapr.Client/DaprClientGrpc.cs](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL0RhcHIuQ2xpZW50L0RhcHJDbGllbnRHcnBjLmNz) | `73.56% <0.00%> (-0.35%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.