dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 340 forks source link

Cascade Terminate/Purge for workflow #1226

Closed shivamkm07 closed 9 months ago

shivamkm07 commented 10 months ago

Describe the feature

Cascade terminate/purge feature for workflow has been added in Dapr runtime. It is enabled by default and can be disabled by passing non_recursive=True in the terminate/purge request.

SDK needs to expose this option to customer.

Reference:

  1. https://github.com/dapr/dapr/pull/7340
  2. https://github.com/microsoft/durabletask-go/pull/47
  3. https://github.com/microsoft/durabletask-dotnet/issues/260

Release Note

RELEASE NOTE:

shivamkm07 commented 10 months ago

PR to support cascade terminate/purge in durabletask-dotnet: https://github.com/microsoft/durabletask-dotnet/pull/262

After this gets merged, will create the PR to surface the option here.

shivamkm07 commented 10 months ago

/assign

halspang commented 9 months ago

I've added the breaking change label here because this is technically a change in core behavior that the user can't opt into. I do understand that this is the desired path so it's more of a bugfix than anything else, but we need to advertise that.

shivamkm07 commented 9 months ago

Closed by #1243