search

dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 340 forks source link

Cascade Terminate/Purge support #1243

Closed shivamkm07 closed 9 months ago

shivamkm07 commented 9 months ago

Description

This PR updates the Microsoft.DurableTask Dependency and makes Recursive as true by default in terminate and purge operations. This makes recursive termination/purge as the default behavior.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1226

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (17b504c) 67.28% compared to head (2707def) 67.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.13 #1243 +/- ## ============================================= Coverage 67.28% 67.28% ============================================= Files 174 174 Lines 6025 6025 Branches 671 671 ============================================= Hits 4054 4054 Misses 1802 1802 Partials 169 169 ``` | [Flag](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [net6](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.26% <ø> (ø)` | | | [net7](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.26% <ø> (ø)` | | | [net8](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.27% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.