dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 340 forks source link

Adds an option to set a timeout for service invocation #1252

Closed elena-kolevska closed 7 months ago

elena-kolevska commented 8 months ago

Description

Adds an option to set a timeout for http and grpc

Issue reference

https://github.com/dapr/dotnet-sdk/issues/1007

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.31%. Comparing base (1b7c9f4) to head (b5962f1). Report is 1 commits behind head on master.

:exclamation: Current head b5962f1 differs from pull request most recent head c37f86b. Consider uploading reports for the commit c37f86b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1252 +/- ## ========================================== + Coverage 67.28% 67.31% +0.02% ========================================== Files 174 174 Lines 6025 6030 +5 Branches 671 672 +1 ========================================== + Hits 4054 4059 +5 Misses 1802 1802 Partials 169 169 ``` | [Flag](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1252/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [net6](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.29% <100.00%> (+0.02%)` | :arrow_up: | | [net7](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.29% <100.00%> (+0.02%)` | :arrow_up: | | [net8](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.29% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcduiker commented 7 months ago

@holopin-bot @elena-kolevska Thanks Elena! 😁

holopin-bot[bot] commented 7 months ago

Congratulations @elena-kolevska, you just earned a badge! Here it is: https://holopin.io/claim/clvdvlg1657300gji363rwirt

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

taufan-mft commented 6 months ago

hi guys, first of all thank you for this PR. I've build this version locally and it solved what I needed. Any idea on when this will be included in the release sir @philliphoff ?

philliphoff commented 5 months ago

@taufan-mft It should be part of the v1.14 Dapr release. You can follow its progress in its release planning issue here: dapr/dapr#7605

taufan-mft commented 5 months ago

thanks a lot! @philliphoff @elena-kolevska