search

dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 340 forks source link

Fix for secret key transformation in multi-value scenarios #1274

Closed philliphoff closed 7 months ago

philliphoff commented 7 months ago

Description

Applies the secret key/name transformation (if specified) only when the returned key name matches the secret key name. If "sub keys" are returned, for example, the transformation makes no sense and results in duplicate key names.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1249

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

philliphoff commented 7 months ago

@jamesmcroft Would appreciate a look if/when you have a chance.

marcduiker commented 6 months ago

@holopin-bot @philliphoff

holopin-bot[bot] commented 6 months ago

Congratulations @philliphoff, you just earned a badge! Here it is: https://holopin.io/claim/clvwg65wa172570fl9qixz1jgq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!