dapr / dotnet-sdk

Dapr SDK for .NET
Apache License 2.0
1.12k stars 340 forks source link

Incremental source generator for actors #1334

Closed m3nax closed 1 month ago

m3nax commented 4 months ago

Description

Converted the Actor source generator into an IncrementalSourceGenerator to ease the future definition of new generation pipeline for other objects (E.g: https://github.com/dapr/dotnet-sdk/issues/1305#issuecomment-2234152155)

It also add a null check for actorProxy parameter passed in generated Actor ctor, definition of AnalyzerReleases.Shipped.md and AnalyzerReleases.Unshipped.md diagnostics, remove deprecated nugets.

Issue reference

_

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.68%. Comparing base (1b7c9f4) to head (6b219d2). Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1334 +/- ## ========================================== + Coverage 67.28% 67.68% +0.39% ========================================== Files 174 175 +1 Lines 6025 6059 +34 Branches 671 675 +4 ========================================== + Hits 4054 4101 +47 + Misses 1802 1788 -14 - Partials 169 170 +1 ``` | [Flag](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1334/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [net6](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1334/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `?` | | | [net7](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1334/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `?` | | | [net8](https://app.codecov.io/gh/dapr/dotnet-sdk/pull/1334/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | `67.68% <ø> (+0.41%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m3nax commented 2 months ago

@KrylixZA really thank for taking time to review my pr.

m3nax commented 1 month ago

@WhitWaldo I have resolved the conflicts with the Master, do you have time to look at this branch?