Closed pimmerks closed 1 year ago
Merging #400 (4f65fbd) into main (f6dccfd) will increase coverage by
0.05%
. The diff coverage is90.90%
.
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 68.93% 68.98% +0.05%
==========================================
Files 31 31
Lines 2479 2483 +4
==========================================
+ Hits 1709 1713 +4
Misses 676 676
Partials 94 94
Impacted Files | Coverage Δ | |
---|---|---|
service/grpc/service.go | 59.64% <90.90%> (+3.04%) |
:arrow_up: |
Thanks for this contribution @pimmerks
We are building an application that exposes it's own gRPC service, it also needs to subscribe to the dapr pub/sub component.
Currently we are allowed to set the listener, but this is not enough, as we found that about half of the time, our own gRPC server responds, and the other half of the time the dapr service responds with an
unknown service xxx.xxx
.If this is merged, the user is allowed to set their own grpcServer with the
NewServiceWithGrpcServer()
func.In action:
In issue https://github.com/dapr/go-sdk/issues/237 the same problem has been found.