Closed JoshVanL closed 11 months ago
Attention: 28 lines
in your changes are missing coverage. Please review.
Comparison is base (
ae8becf
) 68.96% compared to head (d5e92fc
) 69.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Are the grpc
and grpcs
schemas intentional? (They're not parsed)
@mikeee cpuld you elaborate? The schema should be (hopefully!) following https://github.com/dapr/proposals/blob/main/0008-S-sidecar-endpoint-tls.md
In the parser lines 168-169 the grpc/s schemas are permitted yet not parsed as there is no handling for those schemas e.g. grpcs://localhost:443
would result in no target. (I understand this is not what the proposal includes - reading this I would be slightly confused if not for the switch statement not explicitly catching tbe rest of the valid schemas)
PR adds
DAPR_GRPC_ENPOINT
environment variable support to client.Address parser respects http[s] schemes, and TLS query options, as per 0008-S-sidecar-endpoint-tls.md.
DAPR_GRPC_ENDPONT
takes precedence overDAPR_GRPC_PORT
.