search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

fix: update StateConsistency type to match protobufs #481

Closed mikeee closed 9 months ago

mikeee commented 10 months ago

Fixes StateConsistency type to match protobufs, at the moment returns undefined for everything due to the logic.

https://github.com/dapr/dapr/blob/ed3417223c5ea4654f38df1fc5abee93e52cea6e/dapr/proto/common/v1/common.proto#L140

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (61158e8) 70.08% compared to head (86e0e89) 70.26%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #481 +/- ## ========================================== + Coverage 70.08% 70.26% +0.18% ========================================== Files 35 35 Lines 2841 2859 +18 ========================================== + Hits 1991 2009 +18 Misses 738 738 Partials 112 112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikeee commented 9 months ago

Looks like I accidentally committed this to #480 and it was merged. With the latest it implements the recommendations and further unit tests.