search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
443 stars 170 forks source link

perf: enhanced configuration example #483

Closed sadath-12 closed 8 months ago

sadath-12 commented 9 months ago

Eliminated time.sleep with sync.WaitGroup so SubscribeConfigurationItems can take proper time to finish and also updated to more appropriate logs

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (04f7b59) 70.08% compared to head (fc925ed) 70.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #483 +/- ## ======================================= Coverage 70.08% 70.08% ======================================= Files 35 35 Lines 2841 2841 ======================================= Hits 1991 1991 Misses 738 738 Partials 112 112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sadath-12 commented 8 months ago

I agree with this moving towards no time dependency where possible, but it could also be argued that this is a form of validation to ensure that there are no excessive waits.

The mechanical markdown validation hasn't been updated for your revision.

I'm not too sure on the verbiage change being any better than previously. I'd like to see the "with" prefix removed back to the original state

Hmm yeah , also making sure whatever we are passing we are getting it back correctly whereas before the information retrieved was missing from what's sent.