Closed sadath-12 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
04f7b59
) 70.08% compared to head (fc925ed
) 70.08%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I agree with this moving towards no time dependency where possible, but it could also be argued that this is a form of validation to ensure that there are no excessive waits.
The mechanical markdown validation hasn't been updated for your revision.
I'm not too sure on the verbiage change being any better than previously. I'd like to see the "with" prefix removed back to the original state
Hmm yeah , also making sure whatever we are passing we are getting it back correctly whereas before the information retrieved was missing from what's sent.
Eliminated
time.sleep
withsync.WaitGroup
soSubscribeConfigurationItems
can take proper time to finish and also updated to more appropriate logs