search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
443 stars 170 forks source link

PR template added #484

Closed sadath-12 closed 8 months ago

sadath-12 commented 9 months ago

Added pr template as suggested in #449

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (04f7b59) 70.08% compared to head (250714e) 70.08%. Report is 1 commits behind head on main.

:exclamation: Current head 250714e differs from pull request most recent head ec526da. Consider uploading reports for the commit ec526da to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #484 +/- ## ======================================= Coverage 70.08% 70.08% ======================================= Files 35 35 Lines 2841 2841 ======================================= Hits 1991 1991 Misses 738 738 Partials 112 112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sadath-12 commented 8 months ago

Me

I believe the descriptions or context should be in a comment so can be ignored on open rather than having to remove/delete the placeholder text.

Just felt if we need to make sure the contributor must always provide information of what he did instead of making it optional . Please let me know if I am thinking it in right way

sadath-12 commented 8 months ago

thanks done @daixiang0

mikeee commented 8 months ago

To clarify - my opinion is that we should comment out the placeholder/descriptive text so that we provide an indication of what to include and does not include it.

daixiang0 commented 8 months ago

To clarify - my opinion is that we should comment out the placeholder/descriptive text so that we provide an indication of what to include and does not include it.

Agree, @sadath-12 please comment rather than delete.

sadath-12 commented 8 months ago

yeah I get it now thanks @daixiang0 @mikeee