Open sadath-12 opened 9 months ago
Is this a WIP?
Nope its done . Any further suggestions ?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
04f7b59
) 70.08% compared to head (3eba237
) 70.08%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is this a WIP?
Nope its done . Any further suggestions ?
Apologies, I have a bad habit of reviewing when it's late - I'm not sure if I'm reading this correctly but I don't think this PR implements any testing as intended. You're essentially declaring a mock, telling it what to expect (and return) and then giving it what it expects. There is nothing being passed back to the test runtime either.
Then I think we should either correct or implement the mock server properly then we can extend more tests as this pr was just meant to add some minimal tests if we see the issue description also other tests related to statemanager in this repo are not doing anything
I'm not sure what you mean, if I'm reading the contents of this PR correctly - no tests are added.
What other tests are you referring to?
Covers test cases for
actor/state/state_manager.go