dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

feat: workflow authoring and management support #487

Closed mikeee closed 8 months ago

mikeee commented 10 months ago

Implements Workflow authoring using durabletask-go and also an interface to the dapr grpc management endpoints.

Contributes towards the completion of dapr/dapr#7156 and closes #379

This PR also exposes the GRPC connection from the dapr client.

Requires documentation in https://github.com/dapr/docs/pull/3895

codecov[bot] commented 10 months ago

Codecov Report

Attention: 290 lines in your changes are missing coverage. Please review.

Comparison is base (cefbadb) 70.11% compared to head (6f5aa89) 59.37%. Report is 1 commits behind head on main.

Files Patch % Lines
examples/workflow/main.go 0.00% 182 Missing :warning:
workflow/client.go 50.61% 38 Missing and 2 partials :warning:
workflow/worker.go 55.38% 25 Missing and 4 partials :warning:
workflow/workflow.go 54.16% 21 Missing and 1 partial :warning:
workflow/context.go 50.00% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #487 +/- ## =========================================== - Coverage 70.11% 59.37% -10.74% =========================================== Files 35 54 +19 Lines 2884 3483 +599 =========================================== + Hits 2022 2068 +46 - Misses 748 1293 +545 - Partials 114 122 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikeee commented 9 months ago

Implemented the workflow authoring client.

yaron2 commented 9 months ago

Amazing! Thanks @mikeee for adding the authoring code.

yaron2 commented 9 months ago

@cgillum for review

mikeee commented 9 months ago

Apologies for the excess formatting - need to tone down the nvim plugins.

famarting commented 9 months ago

do you know if its possible to add support for setting custom statuses? like here https://github.com/dapr/dotnet-sdk/blob/master/examples/Workflow/WorkflowConsoleApp/Workflows/OrderProcessingWorkflow.cs#L51

mikeee commented 9 months ago

do you know if its possible to add support for setting custom statuses? like here https://github.com/dapr/dotnet-sdk/blob/master/examples/Workflow/WorkflowConsoleApp/Workflows/OrderProcessingWorkflow.cs#L51

Not sure about the setting of custom statuses, I don't believe so at this stage - but I'll have a look into it.

yaron2 commented 9 months ago

Looks like we can merge this. @cgillum

mikeee commented 8 months ago

@yaron2 for your eyes

yaron2 commented 8 months ago

@mikeee please resolve the conflicts and we can merge

mikeee commented 8 months ago

I had a feeling this would happen 😂

mikeee commented 8 months ago

@yaron2 good to go, not sure why codecov is unhappy but 🤷