search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
442 stars 170 forks source link

Update github.com/dapr/dapr to v1.13.0-rc.1 #503

Closed JoshVanL closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4585a36) 70.11% compared to head (9da3c85) 70.11%.

Files Patch % Lines
client/metadata.go 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #503 +/- ## ======================================= Coverage 70.11% 70.11% ======================================= Files 35 35 Lines 2884 2884 ======================================= Hits 2022 2022 Misses 748 748 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yaron2 commented 6 months ago

This is incompatible with Go 1.20 it seems, but not sure what's the solution here

JoshVanL commented 6 months ago

@yaron2 I have reverted the go.mod to use 1.20 as the minimum version which looks to at least compile and keep compatibility.

JoshVanL commented 6 months ago

@yaron2 looking at this more- because dapr/dapr now has a go.mod of 1.21 the go mod tidy & diff check will always fail. One option is disabling the diff check on older go versions.

yaron2 commented 6 months ago

@yaron2 looking at this more- because dapr/dapr now has a go.mod of 1.21 the go mod tidy & diff check will always fail. One option is disabling the diff check on older go versions.

I'm ok with disabling the diff check on older versions. I'm merging this PR for now, please follow up.