search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
442 stars 170 forks source link

Bulkpublisher should return an error #513

Closed mikeee closed 5 months ago

mikeee commented 6 months ago

https://github.com/dapr/go-sdk/blob/7e5ee73aa842660f3bb2c958947d1faa3f665022/client/pubsub.go#L136

pmannam commented 5 months ago

Hi @mikeee, Bulkpublisher already returns an error right? https://github.com/dapr/go-sdk/blob/5ef7aa2234d4d4c07769ad31cde223ef11c4e33e/client/pubsub.go#L172-L179 Can you please elaborate the issue. I would like to work on it. Thanks!

mikeee commented 5 months ago

Having a think about it, this seems the most appropriate way. I didn't like the look of returning a retryid when the eventmap didn't contain it... but I do think the method is handled gracefully.