dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

Implement distributed scheduler building block #562

Closed mikeee closed 2 months ago

mikeee commented 5 months ago

Description

Issue reference

Please reference the issue this PR will close: #561

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 49.31507% with 37 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (27248ba) to head (30601f2). Report is 20 commits behind head on main.

Files Patch % Lines
service/grpc/scheduling.go 0.00% 21 Missing :warning:
client/scheduling.go 78.37% 4 Missing and 4 partials :warning:
service/http/scheduling.go 0.00% 6 Missing :warning:
service/grpc/topic.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #562 +/- ## ========================================== + Coverage 58.04% 61.72% +3.68% ========================================== Files 55 56 +1 Lines 3568 3420 -148 ========================================== + Hits 2071 2111 +40 + Misses 1375 1184 -191 - Partials 122 125 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yaron2 commented 2 months ago

What's needed for this to go out of draft?

mikeee commented 2 months ago

What's needed for this to go out of draft?

I've rerun this and the jobs aren't being invoked (not sure what has changed since the last successful runs a month ago). I'll need to take a look at this tomorrow with fresh eyes

mikeee commented 2 months ago

The answer was right there in the error as always... needed to register a new alpha callbackserver since this was refactored upstream.

yaron2 commented 2 months ago

@mikeee this looks great from my side. ready to merge?