search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

Upgrade gRPC to 1.64.0 #570

Open mikeee opened 4 months ago

mikeee commented 4 months ago

Describe the bug

A client refactor is needed when upgrading to gRPC 1.64.0 The client shouldn't block prior to making RPC calls and instead, use timeouts on the calls rather than the client connection itself.

client/client.go:328:3        staticcheck  SA1019: grpc.WithBlock is deprecated: this DialOption is not supported by NewClient. Will be supported throughout 1.x.
client/client.go:340:15       staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/client.go:376:15       staticcheck  SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/client_test.go:155:12  staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.
client/wait_test.go:106:15    staticcheck  SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x.

To Reproduce

use make lint to describe the deprecated issues and reference docs https://pkg.go.dev/google.golang.org/grpc#DialContext

Expected behavior