search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

make workflow client struct public #577

Closed famarting closed 2 months ago

famarting commented 3 months ago

Description

Make workflow client struct public, so it can be referenced and typed and passed as a variable in other applications.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (27248ba) to head (4c7f25d). Report is 11 commits behind head on main.

Files Patch % Lines
workflow/client.go 84.61% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #577 +/- ## ======================================= Coverage 58.04% 58.04% ======================================= Files 55 55 Lines 3568 3568 ======================================= Hits 2071 2071 Misses 1375 1375 Partials 122 122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ryanwinter commented 2 months ago

I was just trying to figure out why it wasnt public and then this PR popped up :)

marcduiker commented 1 month ago

@holopin-bot @famarting Thank you Fabian!

holopin-bot[bot] commented 1 month ago

Congratulations @famarting, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb807m65250cl0nqqsesax

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!