search

dapr / go-sdk

Dapr SDK for go
Apache License 2.0
446 stars 171 forks source link

Bidirectional Subscriptions #578

Closed JoshVanL closed 2 months ago

JoshVanL commented 3 months ago

Adds support for bidirectional subscriptions to PubSubs. Adds two methods for subscribing- one using a callback and one using an imperative approach. Both giving support to different programming styles or use cases.

Adds example with tests.

Requires daprd built from https://github.com/dapr/dapr/pull/7770

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 2.58621% with 113 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (27248ba) to head (32b4f4b). Report is 18 commits behind head on main.

Files Patch % Lines
client/subscribe.go 0.00% 113 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #578 +/- ## ========================================== + Coverage 58.04% 62.05% +4.00% ========================================== Files 55 53 -2 Lines 3568 3352 -216 ========================================== + Hits 2071 2080 +9 + Misses 1375 1151 -224 + Partials 122 121 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yaron2 commented 2 months ago

the validation step is failing

mikeee commented 2 months ago

the validation step is failing

It fails as the validation is running the latest version of Dapr rather than the RC.

I've validated with RC2 and it's smooth as butter 🙂 we could set the validation workflow to 1.14.0-rc.2 on the release branch if that helps push this through.

yaron2 commented 2 months ago

Can't argue with "smooth as butter" :)

marcduiker commented 1 month ago

@holopin-bot @JoshVanL Thanks Josh!

holopin-bot[bot] commented 1 month ago

Congratulations @JoshVanL, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb8tyf10350cmgajs8h4lq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!