dapr / go-sdk

Dapr SDK for go
Apache License 2.0
441 stars 170 forks source link

Prevent workflows client nilpointer #583

Closed famarting closed 2 weeks ago

famarting commented 2 weeks ago

Description

This PR bumps the durabletask dependency, basically to include this improvement https://github.com/microsoft/durabletask-go/pull/72

Also fixes several functions in the workflows client to prevent a nil pointer error when the taskhub client returns an error and a nil response

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.07%. Comparing base (27248ba) to head (7988166). Report is 12 commits behind head on main.

Files Patch % Lines
workflow/client.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ========================================== + Coverage 58.04% 58.07% +0.02% ========================================== Files 55 55 Lines 3568 3580 +12 ========================================== + Hits 2071 2079 +8 - Misses 1375 1380 +5 + Partials 122 121 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.