dapr / go-sdk

Dapr SDK for go

Apache License 2.0

446 stars 171 forks source link

removed unnecessary warnings from actor reflection #586

Closed thewilli closed 2 months ago

thewilli commented 3 months ago

When checking for valid Actor methods, the SDK no longer emits warnings about invalid or inappropriate method signatures for the ones needed to be implemented for each Actor type.

Fixes #585

Description

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests (hard to test)
[ ] Extended the documentation (side effect removed, no impact on general usage)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.24%. Comparing base (27248ba) to head (6b36a10). Report is 15 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #586 +/- ## ========================================== + Coverage 58.04% 64.24% +6.20% ========================================== Files 55 52 -3 Lines 3568 3247 -321 ========================================== + Hits 2071 2086 +15 + Misses 1375 1039 -336 Partials 122 122 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcduiker commented 1 month ago

@holopin-bot @thewilli Thank you Willi!

holopin-bot[bot] commented 1 month ago

Congratulations @thewilli, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbbf6a201950cjvc8olimrj

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!