dapr / java-sdk

Dapr SDK for Java
Apache License 2.0
262 stars 207 forks source link

Simplify OTEL integration to reduce deps #1160

Closed artur-ciocanu closed 2 weeks ago

artur-ciocanu commented 2 weeks ago

Description

This PR has been created after looking at Micrometer Observation integration in PulsarTemplate here: https://github.com/spring-projects/spring-pulsar/blob/main/spring-pulsar/src/main/java/org/springframework/pulsar/core/PulsarTemplate.java#L298. Many thanks to @salaboy for pointing this out.

The main idea was to remove explicit OTEL dependency from Dapr Messaging since Micrometer Observation should be able to handle traceparent generation behind the scenes and OOTB.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

artur-ciocanu commented 2 weeks ago

@artursouza and @cicoyle this is a tiny PR to get rid of extra dependencies and ensure that we stay in the realm of Spring and Micrometer without having to bring in OTEL explicitly.

Please review and approve! Thank you 🙇