dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
198 stars 84 forks source link

chore(config): updating config API to use v1 endpoint #496

Closed shivamkm07 closed 1 year ago

shivamkm07 commented 1 year ago

Description

This PR updates configuration API implementation to use the v1 stable endpoint instead of alpha1 endpoint.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 1 year ago

Codecov Report

Merging #496 (715690b) into main (b1fb0c2) will decrease coverage by 0.59%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   36.72%   36.14%   -0.59%     
==========================================
  Files          82       82              
  Lines        9927     9927              
  Branches      371      371              
==========================================
- Hits         3646     3588      -58     
- Misses       6222     6280      +58     
  Partials       59       59              
Impacted Files Coverage Δ
.../implementation/Client/GRPCClient/configuration.ts 9.09% <0.00%> (ø)

... and 1 file with indirect coverage changes

shubham1172 commented 1 year ago

Hi @shivamkm07, could you please check the e2e test, looks like it's failing

image

(It still reports passing due to some weird bug).

shubham1172 commented 1 year ago

Awesome

image