search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
194 stars 82 forks source link

added test cases for version check #514

Closed salmankhan-prs closed 1 year ago

salmankhan-prs commented 1 year ago

Description

added a test case to ensure the library has the same version in package.json and package-lock.json

Issue reference

Please reference the issue this PR will close: #505

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 1 year ago

Codecov Report

Merging #514 (40cd611) into main (d20b7dd) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   35.22%   35.22%           
=======================================
  Files          90       90           
  Lines       10142    10142           
  Branches      415      415           
=======================================
  Hits         3573     3573           
  Misses       6503     6503           
  Partials       66       66
salmankhan-prs commented 1 year ago

Hi @shubham1172, Please review this PR and provide your verification. I have imported JSON files using the import statement. Let me know if it should be handled using fs or if any changes are required. Thank you.

shubham1172 commented 1 year ago

Thank you @salmankhan-prs for the PR!!