search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
194 stars 82 forks source link

feat(pubsub): add wildcard support (+, #, $) #517

Closed XavierGeerinck closed 11 months ago

XavierGeerinck commented 1 year ago

Description

This PR adds wildcard support on the PubSub system. This was not possible before due to the way routes were used in unique route registrations. This PR modifies how a route is registered by creating an MD5 of the topic.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #516

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (7686ab0) 100.00% compared to head (679e54e) 100.00%. Report is 3 commits behind head on main.

:exclamation: Current head 679e54e differs from pull request most recent head 68c0e8e. Consider uploading reports for the commit 68c0e8e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #517 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 6 6 Branches 1 1 ========================================= Hits 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dapr-bot commented 1 year ago

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

shubham1172 commented 1 year ago

👋🏻

XavierGeerinck commented 11 months ago

Note stuck at the below for now when running gRPC tests:

time="2023-09-25T08:48:11.820986+02:00" level=error msg="Connection with broker lost; error: EOF" app_id=test-suite-grpc component="pubsub-mqtt (pubsub.mqtt/v1)" instance=Xaviers-MacBook-Pro-2.local scope=dapr.contrib type=log ver=1.11.3
time="2023-09-25T08:48:11.82101+02:00" level=info msg="Attempting to reconnect to broker…" app_id=test-suite-grpc component="pubsub-mqtt (pubsub.mqtt/v1)" instance=Xaviers-MacBook-Pro-2.local scope=dapr.contrib type=log ver=1.11.3
shubham1172 commented 11 months ago

In favor of https://github.com/dapr/js-sdk/pull/529