search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
194 stars 82 forks source link

feat: Support for the `DAPR_HTTP_ENDPOINT` and `DAPR_GRPC_ENDPOINT` environment variables. Adds support for DAPR_API_TOKEN to gRPC client #519

Closed elena-kolevska closed 11 months ago

elena-kolevska commented 12 months ago

Description

Issue reference

Issue this PR will close: #502 and #520

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 11 months ago

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (553affa) 35.23% compared to head (3b27c23) 35.34%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #519 +/- ## ========================================== + Coverage 35.23% 35.34% +0.11% ========================================== Files 90 90 Lines 10143 10187 +44 Branches 415 429 +14 ========================================== + Hits 3574 3601 +27 - Misses 6503 6516 +13 - Partials 66 70 +4 ``` | [Files](https://app.codecov.io/gh/dapr/js-sdk/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [src/utils/Settings.util.ts](https://app.codecov.io/gh/dapr/js-sdk/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL3V0aWxzL1NldHRpbmdzLnV0aWwudHM=) | `70.58% <100.00%> (+17.25%)` | :arrow_up: | | [...mplementation/Client/GRPCClient/GRPCClientProxy.ts](https://app.codecov.io/gh/dapr/js-sdk/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL2ltcGxlbWVudGF0aW9uL0NsaWVudC9HUlBDQ2xpZW50L0dSUENDbGllbnRQcm94eS50cw==) | `15.00% <0.00%> (-0.79%)` | :arrow_down: | | [src/implementation/Client/GRPCClient/GRPCClient.ts](https://app.codecov.io/gh/dapr/js-sdk/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL2ltcGxlbWVudGF0aW9uL0NsaWVudC9HUlBDQ2xpZW50L0dSUENDbGllbnQudHM=) | `76.78% <80.00%> (+0.04%)` | :arrow_up: | | [src/utils/Client.util.ts](https://app.codecov.io/gh/dapr/js-sdk/pull/519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL3V0aWxzL0NsaWVudC51dGlsLnRz) | `43.26% <26.47%> (-2.89%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elena-kolevska commented 11 months ago

@XavierGeerinck and @shubham1172 Thank you both for the review! I updated the PR and commented on some of your questions.

XavierGeerinck commented 11 months ago

Thank you so much! Running the tests now and if they pass we can merge :) thanks again for sticking with us and fixing the URL lib usage