Closed SoTrx closed 10 months ago
Patch coverage: 21.37%
and project coverage change: +0.22%
:tada:
Comparison is base (
553affa
) 35.23% compared to head (2d93a85
) 35.46%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Description
I replaced callbacks in the gRPC client implementation with their promise equivalent.
It uses promisify. I considered wrapping the client itself, but I couldn't do it in a truly type-safe way.
Issue reference
483
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Ps: Sorry for the delay, I kind of forgot that this issue existed to be honest.