search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
194 stars 82 forks source link

Fix actor reminder and timer period parameter #536

Closed heunghingwan closed 10 months ago

heunghingwan commented 11 months ago

Description

Allow undefined reminder and timer periods

Issue reference

issue this PR will close: #535

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

shubham1172 commented 10 months ago

Hi @heunghingwan, could you please add a test for this too? You could update the implementation here https://github.com/dapr/js-sdk/blob/main/test/actor/DemoActorReminderImpl.ts to take in a parameterized period, and use it in an e2e test.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b063e10) 100.00% compared to head (21aaa6f) 35.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #536 +/- ## ============================================ - Coverage 100.00% 35.28% -64.72% ============================================ Files 1 91 +90 Lines 6 10445 +10439 Branches 1 410 +409 ============================================ + Hits 6 3686 +3680 - Misses 0 6700 +6700 - Partials 0 59 +59 ``` | [Files](https://app.codecov.io/gh/dapr/js-sdk/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr) | Coverage Δ | | |---|---|---| | [src/actors/client/ActorClient/ActorClientHTTP.ts](https://app.codecov.io/gh/dapr/js-sdk/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr#diff-c3JjL2FjdG9ycy9jbGllbnQvQWN0b3JDbGllbnQvQWN0b3JDbGllbnRIVFRQLnRz) | `4.54% <0.00%> (ø)` | | ... and [89 files with indirect coverage changes](https://app.codecov.io/gh/dapr/js-sdk/pull/536/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dapr)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.