dapr / js-sdk

Dapr SDK for Javascript

Apache License 2.0

194 stars 82 forks source link

Closed fyzact closed 9 months ago

fyzact commented 9 months ago

fix how define dapr server to it can work directly when you copy

Description

Please explain the changes you've made

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Please make sure you've completed the relevant tasks for this PR, out of the following list:

shubham1172 commented 9 months ago

Hi, thanks for the PR, the code is self-explanatory there because of L104.

fyzact commented 9 months ago

Hi, thanks for the PR, the code is self-explanatory there because of L104.

thanks for explanition, to me it was more aboout to fix the sample as it was not working directly when you copy.

shubham1172 commented 9 months ago

Oh I just noticed the comma missing, thanks for pointing it out.

fyzact commented 9 months ago

Oh I just noticed the comma missing, thanks for pointing it out.

in fact, after pr I found too many issue like that, will fix all of them and raise new and more comprehensive pr next week hopefully.

shubham1172 commented 9 months ago

That would be awesome, thanks a lot!